Skip to content

Migrate to motely-wasm 31 and jaml-ui 10; drop JS JAML glue - #9

Merged
OptimusPi merged 7 commits into
masterfrom
claude/gallant-dirac-q5pgwf
Nov 8, 2026
Merged

OptimusPi merged 7 commits into
masterfrom
claude/gallant-dirac-q5pgwf

Conversation

@OptimusPi

Copy link
Copy Markdown
Owner

Summary

  • Search worker moves to motely-wasm 31. motely-wasm parses JAML itself, so jamlDocumentParse.ts, the base64 polyfill and js-yaml are gone.
  • JamlView mounts jaml-ui's JamlIde directly.
  • Deletes stale agent instructions: CLAUDE.md named MotelyWasm / MotelyWasmEvents, which motely-wasm 31 does not export, and .github/copilot-instructions.md described js-yaml, thread counts and Mantine-first UI.

Blocked on

vite build fails until jaml-ui 10.1.0 is published to npm. 10.0.0 (current latest) does not export JamlIde, JamlIdeSearchResult, JimboRow, JimboText or jaml-ui/jimbo.css; the 10.1.0 release commit in jaml-ui does. After publishing, bump jaml-ui to ^10.1.0 here and import JimboTextInput from jaml-ui/ui.

Checks

  • vitest run: 589 passed
  • eslint src: 0 errors
  • vite build: fails, see above

Generated by Claude Code

31 drops the static Search class. Filters load through
JamlConfigLoader.check/fromJaml, JamlSearchBuilder.createSettings builds
the search, progress and scored results come through callbacks, and the
started search is awaited and disposed. Thrown NativeAOT exceptions are
replaced by Errors.last(), so a bad filter shows the loader's reason.
CancellationToken is the package's own now. Scored results carry
`tallies` instead of `tally`.

Blocked on jaml-ui: 4.6 imports `Analyze`, which 31 removed, so the build
fails until jaml-ui publishes against 31.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJq1K4w3RNNmNtQ214gAo1
Does not build yet: jaml-ui 10 has no JAML IDE. Waits for the jaml-ui
release that adds it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJq1K4w3RNNmNtQ214gAo1
… JamlIde

The worker loads filters with JamlConfigLoader and searches the filter's own
seeds: list when it has one, else a random sample. Deleted the js-yaml
document parser, its spec, the base64 polyfill and the bundle branch in
parseSeedList. Needs jaml-ui 10.1.0 (JamlIde export) on npm.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJq1K4w3RNNmNtQ214gAo1
CLAUDE.md told agents to import MotelyWasm and MotelyWasmEvents, which
motely-wasm 31 does not export. copilot-instructions.md described js-yaml,
thread counts and Mantine-first UI, all of which the code no longer uses.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJq1K4w3RNNmNtQ214gAo1
@greptile-apps

greptile-apps Bot commented Nov 7, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes affect JAML searches and their connection to Blueprint’s seed queue.

The search and seed viewer still use different deck or stake settings when an override is selected, so this PR needs a fix before merging.

Findings

  1. P1 Search and viewer settings disagree ▶

Summary

Moves JAML parsing into motely-wasm 31 and mounts JamlIde directly.

  • JAML searches now use motely-wasm’s filter loader.
  • JAML files now load their filter seeds into Blueprint.
  • Old agent notes no longer describe the app’s JAML setup.

Reviews (3) · Last reviewed commit: "Import JimboTextInput from jaml-ui/ui" · Reviewed by Greptile

Comment on lines +74 to +75
deck: MotelyDeck[filter.deck],
stake: MotelyStake[filter.stake],

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Search and viewer settings disagree

Loading a seed file keeps the selected deck and stake overrides, but the loaded message reports only the file’s values. Loading a Ghost-deck file while Red is selected therefore searches on Red but sets the seed viewer to Ghost. Users can then see results that disagree with the search. Previously, loading a file reset the overrides to the file’s values.

Report the effective deck and stake after applying overrides so the search and seed viewer agree.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJq1K4w3RNNmNtQ214gAo1
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01KJq1K4w3RNNmNtQ214gAo1
@OptimusPi
OptimusPi merged commit d6368ae into master Nov 8, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants